Skip to content

Conversation

@avorylli
Copy link

Resolves #1356

Adds TypeDoc API reference links for the web SDK to improve documentation discoverability.

Updated main README to include web-client component and added API Reference section in Docusaurus web-client index page.

Added API reference section and improved formatting.
Added TypeDoc API reference links for web SDK in documentation and made several breaking changes to the AuthSecretKey and WebClient components.
@Keinberger
Copy link
Collaborator

Not sure if we do want to have that linked in our Miden Docs, @BrianSeong99 what do you think?

@BrianSeong99
Copy link

The migration is expected in the coming weeks, maybe we could add it then with the correct link?

Copy link
Contributor

@WiktorStarczewski WiktorStarczewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comment

README.md Outdated

- `miden-client` library, which can be used by other project to programmatically interact with the Miden rollup. You can find more information about the library in the [Rust client Library](./crates/rust-client/README.md) section.
- `miden-client-cli`, which is a wrapper around the library exposing its functionality via a simple command-line interface (CLI). You can find more information about the CLI in the [Miden client CLI](./bin/miden-cli/README.md) section.
- `@demox-labs/miden-sdk` (web client), which is a browser-focused SDK for interacting with the Miden rollup from web applications. You can find more information about the web client in the [Web Client README](./crates/web-client/README.md) section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change that to @miden-sdk/miden-sdk

@Keinberger
Copy link
Collaborator

The migration is expected in the coming weeks, maybe we could add it then with the correct link?

I think it's fine to add it for now. We will amend the docs later on anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decide where to link typedoc documentation for web SDK

4 participants