-
Notifications
You must be signed in to change notification settings - Fork 81
feat(docs): add TypeDoc API reference links for web SDK #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
Added API reference section and improved formatting.
Added TypeDoc API reference links for web SDK in documentation and made several breaking changes to the AuthSecretKey and WebClient components.
|
Not sure if we do want to have that linked in our Miden Docs, @BrianSeong99 what do you think? |
|
The migration is expected in the coming weeks, maybe we could add it then with the correct link? |
WiktorStarczewski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comment
README.md
Outdated
|
|
||
| - `miden-client` library, which can be used by other project to programmatically interact with the Miden rollup. You can find more information about the library in the [Rust client Library](./crates/rust-client/README.md) section. | ||
| - `miden-client-cli`, which is a wrapper around the library exposing its functionality via a simple command-line interface (CLI). You can find more information about the CLI in the [Miden client CLI](./bin/miden-cli/README.md) section. | ||
| - `@demox-labs/miden-sdk` (web client), which is a browser-focused SDK for interacting with the Miden rollup from web applications. You can find more information about the web client in the [Web Client README](./crates/web-client/README.md) section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change that to @miden-sdk/miden-sdk
I think it's fine to add it for now. We will amend the docs later on anyways. |
Resolves #1356
Adds TypeDoc API reference links for the web SDK to improve documentation discoverability.
Updated main README to include web-client component and added API Reference section in Docusaurus web-client index page.